Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove good second issue 5617 #5682

Merged

Conversation

tkozek
Copy link
Member

@tkozek tkozek commented Oct 8, 2023

Fixes #5617

What changes did you make?

-Removed the following line from CONTRIBUTING.md Section 2.3.c:

* Prioritized Backlog column in the [filtered Project Board - **complexity: Good second issues** label](https://github.com/hackforla/website/projects/7?card_filter_query=label%3A%22complexity%3A+good+second+issue%22+label%3A%22role%3A+back+end%2Fdevops%22)

Why did you make the changes?

-In order to eliminate confusion, since Hack for LA is no longer creating issues with the "good second issue" label
-For Reviewers: Do not review changes locally, rather, review changes at:

https://github.com/tkozek/website/blob/remove-good-second-issue-5617/CONTRIBUTING.md#23c-available-issues-for-returning-members-back-end

Screenshots of Proposed Changes Of The Website

Before:
image

After:

image

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b tkozek-remove-good-second-issue-5617 gh-pages
git pull https://github.com/tkozek/website.git remove-good-second-issue-5617

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Wiki Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Oct 8, 2023
@JanineSooThow JanineSooThow self-requested a review October 9, 2023 09:07
@JanineSooThow
Copy link
Member

Availability: Tuesdays NZT
ETA: Before Wednesday 11th October

Copy link
Member

@JanineSooThow JanineSooThow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @tkozek on the changes. Changes made were applicable :) Good job!

@robertnjenga robertnjenga self-requested a review October 10, 2023 16:09
@robertnjenga
Copy link
Member

Review ETA: 10/10/2023
Availability: 10am - 2pm

Copy link
Member

@robertnjenga robertnjenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tkozek Great job with the issue!
The branching is set up correctly.
You linked the issue.
Changes appear correctly in the test URL. Well done!

@drakenguyen4000 drakenguyen4000 merged commit c0ac532 into hackforla:gh-pages Oct 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "good second issue" from CONTRIBUTING.md Section 2.3.c
4 participants